Commit 8b550eb6 authored by Deepak R Varma's avatar Deepak R Varma Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192u: remove unnecessary function implementation 



This driver is a single standalone driver and does not have any loading
dependencies on another associated drivers. The build results in one
single .ko object. The current implementation of the function
ieee80211_tkip_null simply returns back to the caller without any useful
instruction executions. It does not lead to auto-loading of any other
associated modules as the initial design implementation appears to be.

Hence the call to ieee80211_tkip_null() and its implementation is
unnecessary and should be removed.

Signed-off-by: default avatarDeepak R Varma <drv@mailo.com>
Link: https://lore.kernel.org/r/6f5a4313fc21365bf733c25385aef79554ffb253.1667237959.git.drv@mailo.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dba2628c

drivers/staging/rtl8192u/ieee80211/ieee80211.h

+0 −3
Original line number Diff line number Diff line
@@ -232,8 +232,6 @@ struct cb_desc { 


#define ieee80211_ccmp_null		ieee80211_ccmp_null_rsl



#define ieee80211_tkip_null		ieee80211_tkip_null_rsl



#define free_ieee80211			free_ieee80211_rsl

#define alloc_ieee80211			alloc_ieee80211_rsl
@@ -2256,7 +2254,6 @@ void ieee80211_ps_tx_ack(struct ieee80211_device *ieee, short success); 
void softmac_mgmt_xmit(struct sk_buff *skb, struct ieee80211_device *ieee);



/* ieee80211_crypt_ccmp&tkip&wep.c */

void ieee80211_tkip_null(void);



int ieee80211_crypto_init(void);

void ieee80211_crypto_deinit(void);

drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c

+0 −6
Original line number Diff line number Diff line
@@ -716,9 +716,3 @@ void ieee80211_crypto_tkip_exit(void) 
{

	ieee80211_unregister_crypto_ops(&ieee80211_crypt_tkip);

}
 


void ieee80211_tkip_null(void)

{

//    printk("============>%s()\n", __func__);

	return;

}

drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

+0 −3
Original line number Diff line number Diff line
@@ -159,9 +159,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv) 
		ieee->last_packet_time[i] = 0;

	}



/* These function were added to load crypte module autoly */

	ieee80211_tkip_null();



	return dev;



 failed: