Commit 8be29504 authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Deucher
Browse files

drm/amdkfd: potential error pointer dereference in ioctl 



The "target" either comes from kfd_create_process() which returns error
pointers on error or kfd_lookup_process_by_pid() which returns NULL on
error.  So we need to check for both types of errors.

Fixes: 0ab2d753 ("drm/amdkfd: prepare per-process debug enable and disable")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarJonathan Kim <jonathan.kim@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 33e82119

drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

+2 −2
Original line number Diff line number Diff line
@@ -2920,9 +2920,9 @@ static int kfd_ioctl_set_debug_trap(struct file *filep, struct kfd_process *p, v 
		target = kfd_lookup_process_by_pid(pid);

	}



	if (!target) {

	if (IS_ERR_OR_NULL(target)) {

		pr_debug("Cannot find process PID %i to debug\n", args->pid);

		r = -ESRCH;

		r = target ? PTR_ERR(target) : -ESRCH;

		goto out;

	}