Commit 8c4d35af authored by Peng Fan's avatar Peng Fan Committed by Greg Kroah-Hartman
Browse files

nvmem: imx: scu: correct the fuse word index



i.MX8 fuse word row index represented as one 4-bytes word.
Exp:
- MAC0 address layout in fuse:
offset 708: MAC[3] MAC[2] MAC[1] MAC[0]
offset 709: XX     xx     MAC[5] MAC[4]

The original code takes row index * 4 as the offset, this
not exactly match i.MX8 fuse map documentation.

So update code the reflect the truth.

Signed-off-by: default avatarPeng Fan <peng.fan@nxp.com>
Reviewed-by: default avatarFugang Duan <fugang.duan@nxp.com>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200109104017.6249-3-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 40bb95db
Loading
Loading
Loading
Loading
+5 −5
Original line number Diff line number Diff line
@@ -138,8 +138,8 @@ static int imx_scu_ocotp_read(void *context, unsigned int offset,
	void *p;
	int i, ret;

	index = offset >> 2;
	num_bytes = round_up((offset % 4) + bytes, 4);
	index = offset;
	num_bytes = round_up(bytes, 4);
	count = num_bytes >> 2;

	if (count > (priv->data->nregs - index))
@@ -168,7 +168,7 @@ static int imx_scu_ocotp_read(void *context, unsigned int offset,
		buf++;
	}

	memcpy(val, (u8 *)p + offset % 4, bytes);
	memcpy(val, (u8 *)p, bytes);

	mutex_unlock(&scu_ocotp_mutex);

@@ -188,10 +188,10 @@ static int imx_scu_ocotp_write(void *context, unsigned int offset,
	int ret;

	/* allow only writing one complete OTP word at a time */
	if ((bytes != 4) || (offset % 4))
	if (bytes != 4)
		return -EINVAL;

	index = offset >> 2;
	index = offset;

	if (in_hole(context, index))
		return -EINVAL;