Commit 8c55a99d authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

parport: Use string_upper() instead of open coded variant 



Use string_upper() from string helper module instead of open coded variant.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210518133458.20403-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d3a2bfde

drivers/parport/probe.c

+3 −8
Original line number Diff line number Diff line
@@ -8,8 +8,8 @@ 


#include <linux/module.h>

#include <linux/parport.h>

#include <linux/ctype.h>

#include <linux/string.h>

#include <linux/string_helpers.h>

#include <linux/slab.h>

#include <linux/uaccess.h>
@@ -74,11 +74,7 @@ static void parse_data(struct parport *port, int device, char *str) 
			u = sep + strlen (sep) - 1;

			while (u >= p && *u == ' ')

				*u-- = '\0';

			u = p;

			while (*u) {

				*u = toupper(*u);

				u++;

			}

			string_upper(p, p);

			if (!strcmp(p, "MFG") || !strcmp(p, "MANUFACTURER")) {

				kfree(info->mfr);

				info->mfr = kstrdup(sep, GFP_KERNEL);
@@ -90,8 +86,7 @@ static void parse_data(struct parport *port, int device, char *str) 


				kfree(info->class_name);

				info->class_name = kstrdup(sep, GFP_KERNEL);

				for (u = sep; *u; u++)

					*u = toupper(*u);

				string_upper(sep, sep);

				for (i = 0; classes[i].token; i++) {

					if (!strcmp(classes[i].token, sep)) {

						info->class = i;