include, lib: add __printf attributes to several function prototypes
Using __printf attributes helps to detect several format string issues at compile time (even though -Wformat-security is currently disabled in Makefile). For example it can detect when formatting a pointer as a number, like the issue fixed in commit a3fa71c4 ("wl18xx: show rx_frames_per_rates as an array as it really is"), or when the arguments do not match the format string, c.f. for example commit 5ce1aca8 ("reiserfs: fix __RASSERT format string"). To prevent similar bugs in the future, add a __printf attribute to every function prototype which needs one in include/linux/ and lib/. These functions were mostly found by using gcc's -Wsuggest-attribute=format flag. Signed-off-by:Nicolas Iooss <nicolas.iooss_linux@m4x.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Felipe Balbi <balbi@ti.com> Cc: Joel Becker <jlbec@evilplan.org> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- include/linux/clkdev.h 4 additions, 3 deletionsinclude/linux/clkdev.h
- include/linux/compat.h 1 addition, 1 deletioninclude/linux/compat.h
- include/linux/configfs.h 2 additions, 1 deletioninclude/linux/configfs.h
- include/linux/cpu.h 4 additions, 3 deletionsinclude/linux/cpu.h
- include/linux/dcache.h 2 additions, 1 deletioninclude/linux/dcache.h
- include/linux/device.h 7 additions, 8 deletionsinclude/linux/device.h
- include/linux/iommu.h 1 addition, 1 deletioninclude/linux/iommu.h
- include/linux/kernel.h 5 additions, 4 deletionsinclude/linux/kernel.h
- include/linux/kobject.h 3 additions, 2 deletionsinclude/linux/kobject.h
- include/linux/mmiotrace.h 1 addition, 1 deletioninclude/linux/mmiotrace.h
- include/linux/printk.h 3 additions, 3 deletionsinclude/linux/printk.h
- lib/kobject.c 3 additions, 2 deletionslib/kobject.c
Loading
Please register or sign in to comment