Skip to content
Commit 8ef9ba4d authored by Oliver Herms's avatar Oliver Herms Committed by Jakub Kicinski
Browse files

IPv6: Set SIT tunnel hard_header_len to zero



Due to the legacy usage of hard_header_len for SIT tunnels while
already using infrastructure from net/ipv4/ip_tunnel.c the
calculation of the path MTU in tnl_update_pmtu is incorrect.
This leads to unnecessary creation of MTU exceptions for any
flow going over a SIT tunnel.

As SIT tunnels do not have a header themsevles other than their
transport (L3, L2) headers we're leaving hard_header_len set to zero
as tnl_update_pmtu is already taking care of the transport headers
sizes.

This will also help avoiding unnecessary IPv6 GC runs and spinlock
contention seen when using SIT tunnels and for more than
net.ipv6.route.gc_thresh flows.

Fixes: c5441932 ("GRE: Refactor GRE tunneling code.")
Signed-off-by: default avatarOliver Herms <oliver.peter.herms@gmail.com>
Acked-by: default avatarWillem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20201103104133.GA1573211@tws


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4e0396c5
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment