Commit 8fc7a619 authored by Antonio Borneo's avatar Antonio Borneo Committed by Marc Zyngier
Browse files

irqchip/stm32-exti: Remove check on always false condition 



The field drv_data is assigned during driver's probe, where it's
already checked to be not NULL.

Remove the always false check '!host_data->drv_data'.

This fixes a warning "variable dereferenced before check" detected
by '0-DAY CI Kernel Test Service'.

Fixes: c2974933 ("irqchip/stm32-exti: Simplify irq description table")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/lkml/202208131739.gJvcs9ls-lkp@intel.com/


Signed-off-by: default avatarAntonio Borneo <antonio.borneo@foss.st.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220817125758.5975-1-antonio.borneo@foss.st.com
parent b90cb105

drivers/irqchip/irq-stm32-exti.c

+1 −1
Original line number Diff line number Diff line
@@ -716,7 +716,7 @@ static int stm32_exti_h_domain_alloc(struct irq_domain *dm, 


	irq_domain_set_hwirq_and_chip(dm, virq, hwirq, chip, chip_data);



	if (!host_data->drv_data || !host_data->drv_data->desc_irqs)

	if (!host_data->drv_data->desc_irqs)

		return -EINVAL;



	desc_irq = host_data->drv_data->desc_irqs[hwirq];