Commit 901181b7 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Mauro Carvalho Chehab
Browse files

media: tw5864: Simplify 'tw5864_finidev()' 



Some resources are allocated with 'pci_request_regions()', so use
'pci_release_regions()' to free them, instead of a verbose
'release_mem_region()'.

There is no point in calling 'devm_kfree()'. The corresponding resource is
managed, so it will be fried automatically.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 20c82fff

drivers/media/pci/tw5864/tw5864-core.c

+1 −3
Original line number Diff line number Diff line
@@ -333,11 +333,9 @@ static void tw5864_finidev(struct pci_dev *pci_dev) 


	/* release resources */

	iounmap(dev->mmio);

	release_mem_region(pci_resource_start(pci_dev, 0),

			   pci_resource_len(pci_dev, 0));

	pci_release_regions(pci_dev);



	v4l2_device_unregister(&dev->v4l2_dev);

	devm_kfree(&pci_dev->dev, dev);

}



static struct pci_driver tw5864_pci_driver = {