Commit 909111ba authored by Zhen Lei's avatar Zhen Lei Committed by Joerg Roedel
Browse files

iommu: Avoid unnecessary assignment of dev->iommu_fwspec 



Move the assignment statement into if branch above, where it only
needs to be.

Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent a1831bb9

drivers/iommu/iommu.c

+2 −1
Original line number Diff line number Diff line
@@ -1869,13 +1869,14 @@ int iommu_fwspec_add_ids(struct device *dev, u32 *ids, int num_ids) 
		fwspec = krealloc(dev->iommu_fwspec, size, GFP_KERNEL);

		if (!fwspec)

			return -ENOMEM;



		dev->iommu_fwspec = fwspec;

	}



	for (i = 0; i < num_ids; i++)

		fwspec->ids[fwspec->num_ids + i] = ids[i];



	fwspec->num_ids += num_ids;

	dev->iommu_fwspec = fwspec;

	return 0;

}

EXPORT_SYMBOL_GPL(iommu_fwspec_add_ids);