Commit 90b58d96 authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Greg Kroah-Hartman
Browse files

pstore/ram: Fix error handling during przs allocation 



persistent_ram_new() returns ERR_PTR() value on errors, so during
freeing of the przs we should check for both NULL and IS_ERR() entries,
otherwise bad things will happen.

Signed-off-by: default avatarAnton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 924d3711

fs/pstore/ram.c

+1 −1
Original line number Diff line number Diff line
@@ -260,7 +260,7 @@ static void ramoops_free_przs(struct ramoops_context *cxt) 
	if (!cxt->przs)

		return;



	for (i = 0; cxt->przs[i]; i++)

	for (i = 0; !IS_ERR_OR_NULL(cxt->przs[i]); i++)

		persistent_ram_free(cxt->przs[i]);

	kfree(cxt->przs);

}