Commit 94afce19 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: Remove useless msleep(10) before power-on on BYT 

On BYT on poweron/runtime-resume the code is doing:

1. Do nothing
2. msleep(10)
3. Start actual poweron sequence

Since the runtime resume can happen at any moment, waiting 10ms
after it does not really make any sense.

According to both the comment and to:
https://github.com/intel/ProductionKernelQuilts/blob/master/uefi/cht-m1stable/patches/cam-0341-atomisp-WA-sleep-10ms-when-power-up-ISP-on-byt.patch



Which is the patch which originally added this this was added
as a workaround for a single test failing on a single model
tablet/laptop. So lets just drop this.

Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent e6548795

drivers/staging/media/atomisp/pci/atomisp_v4l2.c

+0 −8
Original line number Diff line number Diff line
@@ -665,14 +665,6 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) 
		msleep(20);

	}



	/*

	 * FIXME:WA for ECS28A, with this sleep, CTS

	 * android.hardware.camera2.cts.CameraDeviceTest#testCameraDeviceAbort

	 * PASS, no impact on other platforms

	 */

	if (IS_BYT && enable)

		msleep(10);



	/* Write to ISPSSPM0 bit[1:0] to power on/off the IUNIT */

	iosf_mbi_modify(BT_MBI_UNIT_PMC, MBI_REG_READ, MRFLD_ISPSSPM0,

			val, MRFLD_ISPSSPM0_ISPSSC_MASK);