Commit 96670657 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: keep io_req_free_batch() call locality 



Don't do a function call (io_dismantle_req()) in the middle and place it
to near other function calls, otherwise may lead to excessive register
spilling.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent cf27f3b1

fs/io_uring.c

+1 −1
Original line number Diff line number Diff line
@@ -2112,6 +2112,7 @@ static void io_req_free_batch(struct req_batch *rb, struct io_kiocb *req, 
			      struct io_submit_state *state)

{

	io_queue_next(req);

	io_dismantle_req(req);



	if (req->task != rb->task) {

		if (rb->task)
@@ -2122,7 +2123,6 @@ static void io_req_free_batch(struct req_batch *rb, struct io_kiocb *req, 
	rb->task_refs++;

	rb->ctx_refs++;



	io_dismantle_req(req);

	if (state->free_reqs != ARRAY_SIZE(state->reqs))

		state->reqs[state->free_reqs++] = req;

	else