Commit 99352c79 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Jakub Kicinski
Browse files

net: freescale: select CONFIG_FIXED_PHY where needed 



I ran into a randconfig build failure with CONFIG_FIXED_PHY=m
and CONFIG_GIANFAR=y:

x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418): undefined reference to `fixed_phy_change_carrier'

It seems the same thing can happen with dpaa and ucc_geth, so change
all three to do an explicit 'select FIXED_PHY'.

The fixed-phy driver actually has an alternative stub function that
theoretically allows building network drivers when fixed-phy is
disabled, but I don't see how that would help here, as the drivers
presumably would not work then.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 57644431

drivers/net/ethernet/freescale/Kconfig

+2 −0
Original line number Original line Diff line number Diff line
@@ -77,6 +77,7 @@ config UCC_GETH 
	depends on QUICC_ENGINE && PPC32

	depends on QUICC_ENGINE && PPC32

	select FSL_PQ_MDIO

	select FSL_PQ_MDIO

	select PHYLIB

	select PHYLIB

	select FIXED_PHY

	---help---

	---help---

	  This driver supports the Gigabit Ethernet mode of the QUICC Engine,

	  This driver supports the Gigabit Ethernet mode of the QUICC Engine,

	  which is available on some Freescale SOCs.

	  which is available on some Freescale SOCs.
@@ -90,6 +91,7 @@ config GIANFAR 
	depends on HAS_DMA

	depends on HAS_DMA

	select FSL_PQ_MDIO

	select FSL_PQ_MDIO

	select PHYLIB

	select PHYLIB

	select FIXED_PHY

	select CRC32

	select CRC32

	---help---

	---help---

	  This driver supports the Gigabit TSEC on the MPC83xx, MPC85xx,

	  This driver supports the Gigabit TSEC on the MPC83xx, MPC85xx,

drivers/net/ethernet/freescale/dpaa/Kconfig

+1 −0
Original line number Original line Diff line number Diff line
@@ -3,6 +3,7 @@ menuconfig FSL_DPAA_ETH 
	tristate "DPAA Ethernet"

	tristate "DPAA Ethernet"

	depends on FSL_DPAA && FSL_FMAN

	depends on FSL_DPAA && FSL_FMAN

	select PHYLIB

	select PHYLIB

	select FIXED_PHY

	select FSL_FMAN_MAC

	select FSL_FMAN_MAC

	---help---

	---help---

	  Data Path Acceleration Architecture Ethernet driver,

	  Data Path Acceleration Architecture Ethernet driver,