Commit 9950588a authored by Enric Balletbo i Serra's avatar Enric Balletbo i Serra Committed by Matthias Brugger
Browse files

soc: mediatek: pm-domains: Fix missing error code in scpsys_add_subdomain() 



Adding one power domain in scpsys_add_subdomain is missing to assign an
error code when it fails. Fix that assigning an error code to 'ret',
this also fixes the follwowing smatch warning.

  drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'

Fixes: dd650302 ("soc: mediatek: pm-domains: Don't print an error if child domain is deferred")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20210303091054.796975-1-enric.balletbo@collabora.com


Signed-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
parent 44014763

drivers/soc/mediatek/mtk-pm-domains.c

+3 −2
Original line number Diff line number Diff line
@@ -487,8 +487,9 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren 


		child_pd = scpsys_add_one_domain(scpsys, child);

		if (IS_ERR(child_pd)) {

			dev_err_probe(scpsys->dev, PTR_ERR(child_pd),

				      "%pOF: failed to get child domain id\n", child);

			ret = PTR_ERR(child_pd);

			dev_err_probe(scpsys->dev, ret, "%pOF: failed to get child domain id\n",

				      child);

			goto err_put_node;

		}