Commit 99a7ec2f authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Lee Jones
Browse files

mfd: dln2: Automatically detect and fill endpoint pointers 



The usb_find_common_endpoints() finds and fills the endpoints
in accordance with their types. Use it to automatically detect
and fill endpoint pointers.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220617182338.32402-1-andriy.shevchenko@linux.intel.com
parent 7e47943c

drivers/mfd/dln2.c

+4 −13
Original line number Diff line number Diff line
@@ -91,11 +91,6 @@ struct dln2_mod_rx_slots { 
	spinlock_t lock;

};



enum dln2_endpoint {

	DLN2_EP_OUT	= 0,

	DLN2_EP_IN	= 1,

};



struct dln2_dev {

	struct usb_device *usb_dev;

	struct usb_interface *interface;
@@ -777,16 +772,12 @@ static int dln2_probe(struct usb_interface *interface, 
	int ret;

	int i, j;



	if (hostif->desc.bInterfaceNumber != 0 ||

	    hostif->desc.bNumEndpoints < 2)

	if (hostif->desc.bInterfaceNumber != 0)

		return -ENODEV;



	epout = &hostif->endpoint[DLN2_EP_OUT].desc;

	if (!usb_endpoint_is_bulk_out(epout))

		return -ENODEV;

	epin = &hostif->endpoint[DLN2_EP_IN].desc;

	if (!usb_endpoint_is_bulk_in(epin))

		return -ENODEV;

	ret = usb_find_common_endpoints(hostif, &epin, &epout, NULL, NULL);

	if (ret)

		return ret;



	dln2 = kzalloc(sizeof(*dln2), GFP_KERNEL);

	if (!dln2)