Commit 99e7a944 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: remove write-only HwRxPageSize 



HwRxPageSize from struct hal_data_8188e is set but never read. Remove the
component and the code to initialise it.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210725155902.32433-13-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f3946501

drivers/staging/rtl8188eu/hal/usb_halinit.c

+0 −20
Original line number Diff line number Diff line
@@ -515,26 +515,6 @@ static void usb_AggSettingRxUpdate(struct adapter *Adapter) 
		/*  TODO: */

		break;

	}



	switch (PBP_128) {

	case PBP_128:

		haldata->HwRxPageSize = 128;

		break;

	case PBP_64:

		haldata->HwRxPageSize = 64;

		break;

	case PBP_256:

		haldata->HwRxPageSize = 256;

		break;

	case PBP_512:

		haldata->HwRxPageSize = 512;

		break;

	case PBP_1024:

		haldata->HwRxPageSize = 1024;

		break;

	default:

		break;

	}

}	/*  usb_AggSettingRxUpdate */



static void InitUsbAggregationSetting(struct adapter *Adapter)

drivers/staging/rtl8188eu/include/rtl8188e_hal.h

+0 −1
Original line number Diff line number Diff line
@@ -265,7 +265,6 @@ struct hal_data_8188e { 
	u8	C2hArray[16];

	u8	UsbTxAggMode;

	u8	UsbTxAggDescNum;

	u16	HwRxPageSize;		/*  Hardware setting */



	enum usb_rx_agg_mode UsbRxAggMode;

	u8	UsbRxAggBlockCount;	/*  USB Block count. Block size is

drivers/staging/rtl8188eu/include/rtl8188e_spec.h

+0 −4
Original line number Diff line number Diff line
@@ -803,11 +803,7 @@ So the following defines for 92C is not entire!!!!!! 
#define _PSRX(x)			(x)

#define _PSTX(x)			((x) << 4)



#define PBP_64				0x0

#define PBP_128				0x1

#define PBP_256				0x2

#define PBP_512				0x3

#define PBP_1024			0x4



/* 2 TX/RXDMA */

#define RXDMA_ARBBW_EN			BIT(0)