Commit 9aa32cb5 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp_gmin_platform: Set ELDO1 to 1.6V on devices with an AXP288 PMIC 

Testing on multiple tablet models has shown that Android always uses
1.6V for ELDO1, adjust our code to match.

This also matches with how ELDO1 is used in the DSDTs on these devices,
where for Cherry Trail (ISP2401) based devices ELDO1 is used for an
ACPI power-resource which is named "P16P".

Note on Bay Trail (ISP2400) based devices the power-resource is called
"P15P", which suggests that 1.5V might be a better value there.

Link: https://lore.kernel.org/linux-media/20220116215204.307649-7-hdegoede@redhat.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 74bfe151

drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

+7 −7
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ enum clock_rate { 
#define ELDO_CTRL_REG   0x12



#define ELDO1_SEL_REG	0x19

#define ELDO1_1P8V	0x16

#define ELDO1_1P6V	0x12

#define ELDO1_CTRL_SHIFT 0x00



#define ELDO2_SEL_REG	0x1a
@@ -89,7 +89,7 @@ struct gmin_subdev { 
	u8 pwm_i2c_addr;



	/* For PMIC AXP */

	int eldo1_sel_reg, eldo1_1p8v, eldo1_ctrl_shift;

	int eldo1_sel_reg, eldo1_1p6v, eldo1_ctrl_shift;

	int eldo2_sel_reg, eldo2_1p8v, eldo2_ctrl_shift;

};
@@ -685,9 +685,9 @@ static int gmin_subdev_add(struct gmin_subdev *gs) 
		break;



	case PMIC_AXP:

		gs->eldo1_1p8v = gmin_get_var_int(dev, false,

		gs->eldo1_1p6v = gmin_get_var_int(dev, false,

						  "eldo1_1p8v",

						  ELDO1_1P8V);

						  ELDO1_1P6V);

		gs->eldo1_sel_reg = gmin_get_var_int(dev, false,

						     "eldo1_sel_reg",

						     ELDO1_SEL_REG);
@@ -767,7 +767,7 @@ static int axp_v1p8_on(struct device *dev, struct gmin_subdev *gs) 
	 */

	usleep_range(110, 150);



	ret = axp_regulator_set(dev, gs, gs->eldo1_sel_reg, gs->eldo1_1p8v,

	ret = axp_regulator_set(dev, gs, gs->eldo1_sel_reg, gs->eldo1_1p6v,

				ELDO_CTRL_REG, gs->eldo1_ctrl_shift, true);

	if (ret)

		return ret;
@@ -781,7 +781,7 @@ static int axp_v1p8_off(struct device *dev, struct gmin_subdev *gs) 
{

	int ret;



	ret = axp_regulator_set(dev, gs, gs->eldo1_sel_reg, gs->eldo1_1p8v,

	ret = axp_regulator_set(dev, gs, gs->eldo1_sel_reg, gs->eldo1_1p6v,

				ELDO_CTRL_REG, gs->eldo1_ctrl_shift, false);

	if (ret)

		return ret;