Commit 9bb10b7a authored Feb 10, 2023 by Ayush Gupta Committed by Alex Deucher Feb 28, 2023

drm/amd/display: populate subvp cmd info only for the top pipe



[Why]
System restart observed while changing the display resolution
to 8k with extended mode. Sytem restart was caused by a page fault.

[How]
When the driver populates subvp info it did it for both the pipes using
vblank which caused an outof bounds array access causing the page fault.
added checks to allow the top pipe only to fix this issue.

Co-authored-by: Ayush Gupta <ayush.gupta@amd.com>
Reviewed-by: Alvin Lee <Alvin.Lee2@amd.com>
Acked-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Signed-off-by: Ayush Gupta <ayush.gupta@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 504d3cae

drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -750,7 +750,8 @@ void dc_dmub_setup_subvp_dmub_command(struct dc *dc,
		!pipe->top_pipe && !pipe->prev_odm_pipe &&
		pipe->stream->mall_stream_config.type == SUBVP_MAIN) {
		populate_subvp_cmd_pipe_info(dc, context, &cmd, pipe, cmd_pipe_index++);
		} else if (pipe->plane_state && pipe->stream->mall_stream_config.type == SUBVP_NONE) {
		} else if (pipe->plane_state && pipe->stream->mall_stream_config.type == SUBVP_NONE &&
		!pipe->top_pipe && !pipe->prev_odm_pipe) {
		// Don't need to check for ActiveDRAMClockChangeMargin < 0, not valid in cases where
		// we run through DML without calculating "natural" P-state support
		populate_subvp_cmd_vblank_pipe_info(dc, context, &cmd, pipe, cmd_pipe_index++);