Skip to content
Unverified Commit 9c9c9da7 authored by David Jander's avatar David Jander Committed by Mark Brown
Browse files

spi: spi: Fix queue hang if previous transfer failed



The queue worker always needs to be kicked one final time after a transfer
is done in order to transition to idle (ctlr->busy = false).

Commit 69fa9590 ("spi: Ensure the io_mutex is held until
spi_finalize_current_message()") moved this code into
__spi_pump_messages(), but it was executed only if the transfer was
successful. This condition check causes ctlr-busy to stay true in case of
a failed transfer.
This in turn causes that no new work is ever scheduled to the work queue.

Fixes: 69fa9590 ("spi: Ensure the io_mutex is held until spi_finalize_current_message()")
Reported-by: default avatarVincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: default avatarDavid Jander <david@protonic.nl>
Link: https://lore.kernel.org/r/20220901123630.1098433-1-david@protonic.nl


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b30f7c8e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment