Commit 9e393300 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab
Browse files

media: mtk-vcodec: Use vb2_get_buffer 



Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.

Signed-off-by: default avatarEzequiel Garcia <ezequiel@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil-cisco@xs4all.nl: fixed checkpatch alignment warning]
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 8eebd615

drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c

+10 −4
Original line number Diff line number Diff line
@@ -865,11 +865,17 @@ static int vb2ops_venc_start_streaming(struct vb2_queue *q, unsigned int count) 


err_set_param:

	for (i = 0; i < q->num_buffers; ++i) {

		if (q->bufs[i]->state == VB2_BUF_STATE_ACTIVE) {

		struct vb2_buffer *buf = vb2_get_buffer(q, i);



		/*

		 * FIXME: This check is not needed as only active buffers

		 * can be marked as done.

		 */

		if (buf->state == VB2_BUF_STATE_ACTIVE) {

			mtk_v4l2_debug(0, "[%d] id=%d, type=%d, %d -> VB2_BUF_STATE_QUEUED",

					ctx->id, i, q->type,

					(int)q->bufs[i]->state);

			v4l2_m2m_buf_done(to_vb2_v4l2_buffer(q->bufs[i]),

					(int)buf->state);

			v4l2_m2m_buf_done(to_vb2_v4l2_buffer(buf),

					  VB2_BUF_STATE_QUEUED);

		}

	}