Commit 9f1b19b9 authored by Smita Koralahalli's avatar Smita Koralahalli Committed by Borislav Petkov
Browse files

x86/mce: Avoid unnecessary padding in struct mce_bank 



Convert struct mce_bank member "init" from bool to a bitfield to get rid
of unnecessary padding.

$ pahole -C mce_bank arch/x86/kernel/cpu/mce/core.o

before:

  /* size: 16, cachelines: 1, members: 2 */
  /* padding: 7 */
  /* last cacheline: 16 bytes */

after:

  /* size: 16, cachelines: 1, members: 3 */
  /* last cacheline: 16 bytes */

No functional changes.

Signed-off-by: default avatarSmita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220225193342.215780-2-Smita.KoralahalliChannabasappa@amd.com
parent 31231092

arch/x86/kernel/cpu/mce/core.c

+3 −1
Original line number Diff line number Diff line
@@ -69,7 +69,9 @@ DEFINE_PER_CPU_READ_MOSTLY(unsigned int, mce_num_banks); 


struct mce_bank {

	u64			ctl;			/* subevents to enable */

	bool			init;			/* initialise bank? */



	__u64 init			: 1,		/* initialise bank? */

	      __reserved_1		: 63;

};

static DEFINE_PER_CPU_READ_MOSTLY(struct mce_bank[MAX_NR_BANKS], mce_banks_array);