Commit 9f1e3378 authored by Wei Yongjun's avatar Wei Yongjun Committed by Jakub Kicinski
Browse files

net: ethernet: adi: Fix return value check in adin1110_probe_netdevs() 



In case of error, the function get_phy_device() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Fixes: bc93e19d ("net: ethernet: adi: Add ADIN1110 support")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20220922021023.811581-1-weiyongjun@huaweicloud.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 01bcfc1a

drivers/net/ethernet/adi/adin1110.c

+2 −2
Original line number Diff line number Diff line
@@ -1582,9 +1582,9 @@ static int adin1110_probe_netdevs(struct adin1110_priv *priv) 
		netdev->features |= NETIF_F_NETNS_LOCAL;



		port_priv->phydev = get_phy_device(priv->mii_bus, i + 1, false);

		if (!port_priv->phydev) {

		if (IS_ERR(port_priv->phydev)) {

			netdev_err(netdev, "Could not find PHY with device address: %d.\n", i);

			return -ENODEV;

			return PTR_ERR(port_priv->phydev);

		}



		port_priv->phydev = phy_connect(netdev,