Commit 9fdc63fe authored by Felix Schlepper's avatar Felix Schlepper Committed by Greg Kroah-Hartman
Browse files

Staging: rtl8192e: Using kzalloc and delete memset 



By using kzalloc, we can delete a memset.  The practical difference
is that using kzalloc() will zero out the txb->fragments[] array.
The original code worked fine, but zeroing everything seems nicer.

Signed-off-by: default avatarFelix Schlepper <f3sch.git@outlook.com>
Link: https://lore.kernel.org/r/9727fe31c675f2f3052ca2fa586d137dd856ac91.1656078068.git.f3sch.git@outlook.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 71eac0c0

drivers/staging/rtl8192e/rtllib_tx.c

+1 −2
Original line number Diff line number Diff line
@@ -205,11 +205,10 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size, 
	struct rtllib_txb *txb;

	int i;



	txb = kmalloc(struct_size(txb, fragments, nr_frags), gfp_mask);

	txb = kzalloc(struct_size(txb, fragments, nr_frags), gfp_mask);

	if (!txb)

		return NULL;



	memset(txb, 0, sizeof(struct rtllib_txb));

	txb->nr_frags = nr_frags;

	txb->frag_size = cpu_to_le16(txb_size);