Commit 9fee675c authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman
Browse files

staging: wfx: declare the field 'packet_id' with native byte order 



The field packet_id is not interpreted by the device. It is only used as
identifier for the device answer. So it is not necessary to declare it
little endian. It fixes some warnings raised by Sparse without
complexifying the code.

Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200512150414.267198-12-Jerome.Pouiller@silabs.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b8743c78

drivers/staging/wfx/hif_api_cmd.h

+6 −2
Original line number Diff line number Diff line
@@ -254,7 +254,9 @@ struct hif_ht_tx_parameters { 
} __packed;



struct hif_req_tx {

	__le32 packet_id;

	// packet_id is not interpreted by the device, so it is not necessary to

	// declare it little endian

	u32    packet_id;

	u8     max_tx_rate;

	struct hif_queue queue_id;

	struct hif_data_flags data_flags;
@@ -283,7 +285,9 @@ struct hif_tx_result_flags { 


struct hif_cnf_tx {

	__le32 status;

	__le32 packet_id;

	// packet_id is copied from struct hif_req_tx without been interpreted

	// by the device, so it is not necessary to declare it little endian

	u32    packet_id;

	u8     txed_rate;

	u8     ack_failures;

	struct hif_tx_result_flags tx_result_flags;