Commit a0593290 authored by Alex Elder's avatar Alex Elder Committed by Sage Weil
Browse files

rbd: simplify __rbd_remove_all_snaps() 



This just replaces a while loop with list_for_each_entry_safe()
in __rbd_remove_all_snaps().

Signed-off-by: default avatarAlex Elder <elder@inktank.com>
Reviewed-by: default avatarJosh Durgin <josh.durgin@inktank.com>
parent a66f8c97

drivers/block/rbd.c

+2 −3
Original line number Diff line number Diff line
@@ -1692,12 +1692,11 @@ static int rbd_header_add_snap(struct rbd_device *rbd_dev, 
static void __rbd_remove_all_snaps(struct rbd_device *rbd_dev)

{

	struct rbd_snap *snap;

	struct rbd_snap *next;



	while (!list_empty(&rbd_dev->snaps)) {

		snap = list_first_entry(&rbd_dev->snaps, struct rbd_snap, node);

	list_for_each_entry_safe(snap, next, &rbd_dev->snaps, node)

		__rbd_remove_snap_dev(rbd_dev, snap);

}

}



/*

 * only read the first part of the ondisk header, without the snaps info