Commit a07b8eaf authored by Xin Hao's avatar Xin Hao Committed by Andrew Morton
Browse files

mm/damon: simplify scheme create in lru_sort.c 

In damon_lru_sort_new_hot_scheme() and damon_lru_sort_new_cold_scheme(),
they have so much in common, so we can combine them into a single
function, and we just need to distinguish their differences.

[yangyingliang@huawei.com: change damon_lru_sort_stub_pattern to static]
  Link: https://lkml.kernel.org/r/20220917121228.1889699-1-yangyingliang@huawei.com
Link: https://lkml.kernel.org/r/20220915133041.71819-1-sj@kernel.org


Signed-off-by: default avatarXin Hao <xhao@linux.alibaba.com>
Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Suggested-by: default avatarSeongJae Park <sj@kernel.org>
Reviewed-by: default avatarXin Hao <xhao@linux.alibaba.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 871f697b

mm/damon/lru_sort.c

+17 −22
Original line number Diff line number Diff line
@@ -132,6 +132,18 @@ DEFINE_DAMON_MODULES_DAMOS_STATS_PARAMS(damon_lru_sort_cold_stat, 
		lru_sort_tried_cold_regions, lru_sorted_cold_regions,

		cold_quota_exceeds);



static struct damos_access_pattern damon_lru_sort_stub_pattern = {

	/* Find regions having PAGE_SIZE or larger size */

	.min_sz_region = PAGE_SIZE,

	.max_sz_region = ULONG_MAX,

	/* no matter its access frequency */

	.min_nr_accesses = 0,

	.max_nr_accesses = UINT_MAX,

	/* no matter its age */

	.min_age_region = 0,

	.max_age_region = UINT_MAX,

};



static struct damon_ctx *ctx;

static struct damon_target *target;
@@ -157,36 +169,19 @@ static struct damos *damon_lru_sort_new_scheme( 
/* Create a DAMON-based operation scheme for hot memory regions */

static struct damos *damon_lru_sort_new_hot_scheme(unsigned int hot_thres)

{

	struct damos_access_pattern pattern = {

		/* Find regions having PAGE_SIZE or larger size */

		.min_sz_region = PAGE_SIZE,

		.max_sz_region = ULONG_MAX,

		/* and accessed for more than the threshold */

		.min_nr_accesses = hot_thres,

		.max_nr_accesses = UINT_MAX,

		/* no matter its age */

		.min_age_region = 0,

		.max_age_region = UINT_MAX,

	};

	struct damos_access_pattern pattern = damon_lru_sort_stub_pattern;



	pattern.min_nr_accesses = hot_thres;

	return damon_lru_sort_new_scheme(&pattern, DAMOS_LRU_PRIO);

}



/* Create a DAMON-based operation scheme for cold memory regions */

static struct damos *damon_lru_sort_new_cold_scheme(unsigned int cold_thres)

{

	struct damos_access_pattern pattern = {

		/* Find regions having PAGE_SIZE or larger size */

		.min_sz_region = PAGE_SIZE,

		.max_sz_region = ULONG_MAX,

		/* and not accessed at all */

		.min_nr_accesses = 0,

		.max_nr_accesses = 0,

		/* for min_age or more micro-seconds */

		.min_age_region = cold_thres,

		.max_age_region = UINT_MAX,

	};

	struct damos_access_pattern pattern = damon_lru_sort_stub_pattern;



	pattern.max_nr_accesses = 0;

	pattern.min_age_region = cold_thres;

	return damon_lru_sort_new_scheme(&pattern, DAMOS_LRU_DEPRIO);

}