Commit a0ae5cd2 authored Jul 01, 2021 by Heiko Carstens Committed by Vasily Gorbik Jul 05, 2021

s390/lib,string: fix strcat() inline asm constraint modifier



"dummy" is not only used as output but also as input. Therefore use
the correct "+" constraint modifier.

Fixes: 8cf23c8e ("s390/lib,string: get rid of register asm")
Reported-by: Sven Schnelle <svens@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

parent a029a4ea

arch/s390/lib/string.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -162,7 +162,7 @@ char strcat(char dest, const char *src)
	" jo 0b\n"		" jo 0b\n"
	"1: mvst %[dummy],%[src]\n"		"1: mvst %[dummy],%[src]\n"
	" jo 1b\n"		" jo 1b\n"
	: [dummy] "=&a" (dummy), [dest] "+&a" (dest), [src] "+&a" (src)		: [dummy] "+&a" (dummy), [dest] "+&a" (dest), [src] "+&a" (src)
	:		:
	: "cc", "memory", "0");		: "cc", "memory", "0");
	return ret;		return ret;