Commit a14ca61d authored by Linus Lüssing's avatar Linus Lüssing Committed by Greg Kroah-Hartman
Browse files

Staging: batman-adv: Avoid rounding issues for local hna timeout 



With the current default values, this patch is not critical, as
LOCAL_HNA_TIMEOUT is a multiple of 1000 anyway. However, if someone
would like to change this #define, the person could have some
unexpected rounding issues. Therefore doing the multiplication before
the division now.

Signed-off-by: default avatarLinus Lüssing <linus.luessing@web.de>
Signed-off-by: default avatarSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6e0e9388

drivers/staging/batman-adv/translation-table.c

+1 −1
Original line number Diff line number Diff line
@@ -258,7 +258,7 @@ static void hna_local_purge(struct work_struct *work) 
		hna_local_entry = hashit.bucket->data;



		timeout = hna_local_entry->last_seen +

			((LOCAL_HNA_TIMEOUT / 1000) * HZ);

			((LOCAL_HNA_TIMEOUT * HZ) / 1000);

		if ((!hna_local_entry->never_purge) &&

		    time_after(jiffies, timeout))

			hna_local_del(hna_local_entry, "address timed out");