Commit a19cf5a5 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: mtk-disp: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 9a9174ea

drivers/pwm/pwm-mtk-disp.c

+2 −4
Original line number Diff line number Diff line
@@ -260,13 +260,11 @@ static int mtk_disp_pwm_probe(struct platform_device *pdev) 
	return 0;

}



static int mtk_disp_pwm_remove(struct platform_device *pdev)

static void mtk_disp_pwm_remove(struct platform_device *pdev)

{

	struct mtk_disp_pwm *mdp = platform_get_drvdata(pdev);



	pwmchip_remove(&mdp->chip);



	return 0;

}



static const struct mtk_pwm_data mt2701_pwm_data = {
@@ -314,7 +312,7 @@ static struct platform_driver mtk_disp_pwm_driver = { 
		.of_match_table = mtk_disp_pwm_of_match,

	},

	.probe = mtk_disp_pwm_probe,

	.remove = mtk_disp_pwm_remove,

	.remove_new = mtk_disp_pwm_remove,

};

module_platform_driver(mtk_disp_pwm_driver);