Commit a283de3e authored by Mario Limonciello's avatar Mario Limonciello Committed by Mika Westerberg
Browse files

thunderbolt: Do not resume routers if UID is not set 



Routers might not have a UID set if the DROM read failed during
initialization previously.

Normally upon resume the UID is re-read to confirm it's the same
device connected.
* If the DROM read failed during init but then succeeded during
  resume it could either be a new device or faulty device
* If the DROM read failed during init and also failed during resume
  it might be a different device plugged in all together.

Detect this situation and prevent re-using the same configuration in
these cirucmstances.

Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent e87491a9

drivers/thunderbolt/switch.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -2980,6 +2980,10 @@ int tb_switch_resume(struct tb_switch *sw) 
			return err;

			return err;

		}

		}





		/* We don't have any way to confirm this was the same device */

		if (!sw->uid)

			return -ENODEV;



		if (tb_switch_is_usb4(sw))

		if (tb_switch_is_usb4(sw))

			err = usb4_switch_read_uid(sw, &uid);

			err = usb4_switch_read_uid(sw, &uid);

		else

		else