Commit a2887cd8 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: Remove rsp parameter from rcu_print_detail_task_stall() 



There now is only one rcu_state structure in a given build of the
Linux kernel, so there is no need to pass it as a parameter to RCU's
functions.  This commit therefore removes the rsp parameter from
rcu_print_detail_task_stall().

Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent b8bb1f63

kernel/rcu/tree.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1360,7 +1360,7 @@ static void print_other_cpu_stall(unsigned long gp_seq) 
		rcu_dump_cpu_stacks();

		rcu_dump_cpu_stacks();





		/* Complain about tasks blocking the grace period. */

		/* Complain about tasks blocking the grace period. */

		rcu_print_detail_task_stall(rsp);

		rcu_print_detail_task_stall();

	} else {

	} else {

		if (rcu_seq_current(&rsp->gp_seq) != gp_seq) {

		if (rcu_seq_current(&rsp->gp_seq) != gp_seq) {

			pr_err("INFO: Stall ended before state dump start\n");

			pr_err("INFO: Stall ended before state dump start\n");

kernel/rcu/tree.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -452,7 +452,7 @@ static int rcu_preempt_blocked_readers_cgp(struct rcu_node *rnp); 
#ifdef CONFIG_HOTPLUG_CPU

#ifdef CONFIG_HOTPLUG_CPU

static bool rcu_preempt_has_tasks(struct rcu_node *rnp);

static bool rcu_preempt_has_tasks(struct rcu_node *rnp);

#endif /* #ifdef CONFIG_HOTPLUG_CPU */

#endif /* #ifdef CONFIG_HOTPLUG_CPU */

static void rcu_print_detail_task_stall(struct rcu_state *rsp);

static void rcu_print_detail_task_stall(void);

static int rcu_print_task_stall(struct rcu_node *rnp);

static int rcu_print_task_stall(struct rcu_node *rnp);

static int rcu_print_task_exp_stall(struct rcu_node *rnp);

static int rcu_print_task_exp_stall(struct rcu_node *rnp);

static void rcu_preempt_check_blocked_tasks(struct rcu_state *rsp,

static void rcu_preempt_check_blocked_tasks(struct rcu_state *rsp,

kernel/rcu/tree_plugin.h

+3 −3
Original line number Original line Diff line number Diff line
@@ -683,12 +683,12 @@ static void rcu_print_detail_task_stall_rnp(struct rcu_node *rnp) 
 * Dump detailed information for all tasks blocking the current RCU

 * Dump detailed information for all tasks blocking the current RCU

 * grace period.

 * grace period.

 */

 */

static void rcu_print_detail_task_stall(struct rcu_state *rsp)

static void rcu_print_detail_task_stall(void)

{

{

	struct rcu_node *rnp = rcu_get_root();

	struct rcu_node *rnp = rcu_get_root();





	rcu_print_detail_task_stall_rnp(rnp);

	rcu_print_detail_task_stall_rnp(rnp);

	rcu_for_each_leaf_node(rsp, rnp)

	rcu_for_each_leaf_node(&rcu_state, rnp)

		rcu_print_detail_task_stall_rnp(rnp);

		rcu_print_detail_task_stall_rnp(rnp);

}

}
@@ -1005,7 +1005,7 @@ static void rcu_preempt_deferred_qs(struct task_struct *t) { } 
 * Because preemptible RCU does not exist, we never have to check for

 * Because preemptible RCU does not exist, we never have to check for

 * tasks blocked within RCU read-side critical sections.

 * tasks blocked within RCU read-side critical sections.

 */

 */

static void rcu_print_detail_task_stall(struct rcu_state *rsp)

static void rcu_print_detail_task_stall(void)

{

{

}

}