Commit a32348b7 authored by Maximilian Luz's avatar Maximilian Luz Committed by Hans de Goede
Browse files

platform/surface: dtx: Add missing mutex_destroy() call in failure path 



When we fail to open the device file due to DTX being shut down, the
mutex is initialized but never destroyed. We are destroying it when
releasing the file, so add the missing call in the failure path as well.

Fixes: 1d609992 ("platform/surface: Add DTX driver")
Signed-off-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210604132540.533036-1-luzmaximilian@gmail.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent ae8ee4c1

drivers/platform/surface/surface_dtx.c

+1 −0
Original line number Diff line number Diff line
@@ -427,6 +427,7 @@ static int surface_dtx_open(struct inode *inode, struct file *file) 
	 */

	if (test_bit(SDTX_DEVICE_SHUTDOWN_BIT, &ddev->flags)) {

		up_write(&ddev->client_lock);

		mutex_destroy(&client->read_lock);

		sdtx_device_put(client->ddev);

		kfree(client);

		return -ENODEV;