Commit a327e870 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski
Browse files

dt-bindings: pinctrl: qcom,sm8250: fix matching pin config 



The TLMM pin controller follows generic pin-controller bindings, so
should have subnodes with '-state' and '-pins'.  Otherwise the subnodes
(level one and two) are not properly matched.  This method also unifies
the bindings with other Qualcomm TLMM and LPASS pinctrl bindings.

The change causes indentation decrement, so the diff-hunk looks big, but
there are no functional changes in the subnode "properties" section.
The only difference there is removal of blank lines between common GPIO
pinconf properties.

Acked-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20221016172212.49105-14-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent fd69e8be

Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml

+62 −55
Original line number Diff line number Diff line
@@ -58,13 +58,23 @@ properties: 


  wakeup-parent: true



#PIN CONFIGURATION NODES

patternProperties:

  '^.*$':

    if:

  "-state$":

    oneOf:

      - $ref: "#/$defs/qcom-sm8250-tlmm-state"

      - patternProperties:

          "-pins$":

            $ref: "#/$defs/qcom-sm8250-tlmm-state"

        additionalProperties: false



$defs:

  qcom-sm8250-tlmm-state:

    type: object

    then:

    description:

      Pinctrl node's client devices use subnodes for desired pin configuration.

      Client device subnodes use below standard properties.

    $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state



    properties:

      pins:

        description:
@@ -101,13 +111,10 @@ patternProperties: 
                tsif1_error, tsif1_sync, usb2phy_ac, usb_phy, vsense_trigger ]



      bias-pull-down: true



      bias-pull-up: true



      bias-disable: true

      drive-strength: true

      output-high: true



      output-low: true



    required: