Commit a3417158 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

staging: fieldbus: anybus: Refuse registering drivers without .probe() 



A driver without .probe() callback could never bind to a device because
anybus_bus_probe() returned an error for such a driver. So refuse to
register such a useless driver.

Reviewed-by: default avatarSven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210505202923.198607-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32dcd072

drivers/staging/fieldbus/anybuss/host.c

+3 −2
Original line number Diff line number Diff line
@@ -1183,8 +1183,6 @@ static int anybus_bus_probe(struct device *dev) 
	struct anybuss_client *adev =

		to_anybuss_client(dev);



	if (!adrv->probe)

		return -ENODEV;

	return adrv->probe(adev);

}
@@ -1208,6 +1206,9 @@ static struct bus_type anybus_bus = { 


int anybuss_client_driver_register(struct anybuss_client_driver *drv)

{

	if (!drv->probe)

		return -ENODEV;



	drv->driver.bus = &anybus_bus;

	return driver_register(&drv->driver);

}