Commit a3c19001 authored by Fabio M. De Francesco's avatar Fabio M. De Francesco Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: change the type of a variable in rtw_write16() 



Change the type of "data" from __le32 to __le16 in rtw_write16(). The
argument "val", which is u16, after being conditionally swapped to little
endian, is assigned to "data"; therefore, __le16 is the most suitable type
for "data". Remove the bitwise AND of "val" with 0xffff because it is
redundant. Use cpu_to_le16() because "data" is __le16.

Co-developed-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-9-fmdefrancesco@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7dc3f33c

drivers/staging/r8188eu/hal/usb_ops_linux.c

+1 −1
Original line number Diff line number Diff line
@@ -145,7 +145,7 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val) 
	struct io_priv *io_priv = &adapter->iopriv;

	struct intf_hdl *intf = &io_priv->intf;

	u16 value = addr & 0xffff;

	__le32 data = cpu_to_le32(val & 0x0000ffff);

	__le16 data = cpu_to_le16(val);

	int ret;



	ret = usbctrl_vendorreq(intf, value, &data, 2, REALTEK_USB_VENQT_WRITE);