Commit a4424b90 authored by Dmitry Safonov's avatar Dmitry Safonov Committed by Greg Kroah-Hartman
Browse files

tty/serial: Migrate 8250_omap to use has_sysrq 



The SUPPORT_SYSRQ ifdeffery is not nice as:
- May create misunderstanding about sizeof(struct uart_port) between
  different objects
- Prevents moving functions from serial_core.h
- Reduces readability (well, it's ifdeffery - it's hard to follow)

In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added.
Initialise it in driver's probe and remove ifdeffery.

Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
Link: https://lore.kernel.org/r/20191213000657.931618-8-dima@arista.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 24036fb7

drivers/tty/serial/8250/8250_omap.c

+1 −4
Original line number Diff line number Diff line
@@ -8,10 +8,6 @@ 
 *

 */



#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)

#define SUPPORT_SYSRQ

#endif



#include <linux/clk.h>

#include <linux/device.h>

#include <linux/io.h>
@@ -1192,6 +1188,7 @@ static int omap8250_probe(struct platform_device *pdev) 
	up.port.throttle = omap_8250_throttle;

	up.port.unthrottle = omap_8250_unthrottle;

	up.port.rs485_config = omap_8250_rs485_config;

	up.port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);



	ret = of_alias_get_id(np, "serial");

	if (ret < 0) {