Commit a454969e authored by Ido Yariv's avatar Ido Yariv Committed by Luciano Coelho
Browse files

wl12xx: Power off after flushing work 



When stopping plt, the chip is powered off before all current work items
are flushed and interrupts are disabled. This might introduce a race in
which the driver tries to communicate with a powered off chip.

Fix this by powering off the device only after interrupts are disabled
and all work items are flushed.

Signed-off-by: default avatarIdo Yariv <ido@wizery.com>
Signed-off-by: default avatarLuciano Coelho <coelho@ti.com>
parent f3df1331

drivers/net/wireless/wl12xx/main.c

+5 −2
Original line number Diff line number Diff line
@@ -1406,8 +1406,6 @@ int wl1271_plt_stop(struct wl1271 *wl) 
		goto out;

	}



	wl1271_power_off(wl);



	wl->state = WL1271_STATE_OFF;

	wl->rx_counter = 0;
@@ -1417,6 +1415,11 @@ int wl1271_plt_stop(struct wl1271 *wl) 
	wl1271_flush_deferred_work(wl);

	cancel_work_sync(&wl->netstack_work);

	cancel_work_sync(&wl->recovery_work);



	mutex_lock(&wl->mutex);

	wl1271_power_off(wl);

	mutex_unlock(&wl->mutex);



out:

	return ret;

}