Commit a60b3017 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

misc: ti-st: remove ptr from recv functions 



ptr is the same as data, so use ptr directly as a parameter and drop the
useless local variable.

Likely, the two were introduced to have a different type. But 'char' and
'unsigned char' are the same in the kernel for a long time.

Signed-off-by: default avatarJiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230731080244.2698-10-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 99037697

drivers/misc/ti-st/st_core.c

+1 −3
Original line number Diff line number Diff line
@@ -224,9 +224,8 @@ static inline void st_wakeup_ack(struct st_data_s *st_gdata, 
 *	CH-8 packets from FM, CH-9 packets from GPS cores.

 */

static void st_int_recv(void *disc_data,

	const unsigned char *data, long count)

	const unsigned char *ptr, long count)

{

	char *ptr;

	struct st_proto_s *proto;

	unsigned short payload_len = 0;

	int len = 0;
@@ -235,7 +234,6 @@ static void st_int_recv(void *disc_data, 
	struct st_data_s *st_gdata = (struct st_data_s *)disc_data;

	unsigned long flags;



	ptr = (char *)data;

	/* tty_receive sent null ? */

	if (unlikely(ptr == NULL) || (st_gdata == NULL)) {

		pr_err(" received null from TTY ");

drivers/misc/ti-st/st_kim.c

+1 −3
Original line number Diff line number Diff line
@@ -128,15 +128,13 @@ static inline int kim_check_data_len(struct kim_data_s *kim_gdata, int len) 
 *	tty_receive and hence the logic

 */

static void kim_int_recv(struct kim_data_s *kim_gdata,

	const unsigned char *data, long count)

	const unsigned char *ptr, long count)

{

	const unsigned char *ptr;

	int len = 0;

	unsigned char *plen;



	pr_debug("%s", __func__);

	/* Decode received bytes here */

	ptr = data;

	if (unlikely(ptr == NULL)) {

		pr_err(" received null from TTY ");

		return;