Commit a61c695a authored by Oswald Buddenhagen's avatar Oswald Buddenhagen Committed by Takashi Iwai
Browse files

ALSA: emu10k1: remove useless resets of stop-on-loop-end bits 



We initialize them at card init and don't touch them later, so there is
no need to reset them again at voice start.

Signed-off-by: default avatarOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Link: https://lore.kernel.org/r/20230516093612.3536451-4-oswald.buddenhagen@gmx.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 94dabafe

include/sound/emu10k1.h

+2 −0
Original line number Diff line number Diff line
@@ -1792,8 +1792,10 @@ void snd_emu10k1_voice_intr_ack(struct snd_emu10k1 *emu, unsigned int voicenum); 
void snd_emu10k1_voice_half_loop_intr_enable(struct snd_emu10k1 *emu, unsigned int voicenum);

void snd_emu10k1_voice_half_loop_intr_disable(struct snd_emu10k1 *emu, unsigned int voicenum);

void snd_emu10k1_voice_half_loop_intr_ack(struct snd_emu10k1 *emu, unsigned int voicenum);

#if 0

void snd_emu10k1_voice_set_loop_stop(struct snd_emu10k1 *emu, unsigned int voicenum);

void snd_emu10k1_voice_clear_loop_stop(struct snd_emu10k1 *emu, unsigned int voicenum);

#endif

void snd_emu10k1_wait(struct snd_emu10k1 *emu, unsigned int wait);

static inline unsigned int snd_emu10k1_wc(struct snd_emu10k1 *emu) { return (inl(emu->port + WC) >> 6) & 0xfffff; }

unsigned short snd_emu10k1_ac97_read(struct snd_ac97 *ac97, unsigned short reg);

sound/pci/emu10k1/emupcm.c

+0 −1
Original line number Diff line number Diff line
@@ -603,7 +603,6 @@ static void snd_emu10k1_playback_prepare_voice(struct snd_emu10k1 *emu, struct s 
	vattn = mix != NULL ? (mix->attn[tmp] << 16) : 0;

	snd_emu10k1_ptr_write(emu, VTFT, voice, vattn | VTFT_FILTERTARGET_MASK);

	snd_emu10k1_ptr_write(emu, CVCF, voice, vattn | CVCF_CURRENTFILTER_MASK);

	snd_emu10k1_voice_clear_loop_stop(emu, voice);

}	



static void snd_emu10k1_playback_trigger_voice(struct snd_emu10k1 *emu, struct snd_emu10k1_voice *evoice, int master, int extra)

sound/pci/emu10k1/io.c

+2 −0
Original line number Diff line number Diff line
@@ -434,6 +434,7 @@ void snd_emu10k1_voice_half_loop_intr_ack(struct snd_emu10k1 *emu, unsigned int 
	spin_unlock_irqrestore(&emu->emu_lock, flags);

}



#if 0

void snd_emu10k1_voice_set_loop_stop(struct snd_emu10k1 *emu, unsigned int voicenum)

{

	unsigned long flags;
@@ -471,6 +472,7 @@ void snd_emu10k1_voice_clear_loop_stop(struct snd_emu10k1 *emu, unsigned int voi 
	outl(sol, emu->port + DATA);

	spin_unlock_irqrestore(&emu->emu_lock, flags);

}

#endif



void snd_emu10k1_wait(struct snd_emu10k1 *emu, unsigned int wait)

{