Commit a625ca30 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Leon Romanovsky
Browse files

RDMA/rxe: Fix "kernel NULL pointer dereference" error 

When rxe_queue_init in the function rxe_qp_init_req fails,
both qp->req.task.func and qp->req.task.arg are not initialized.

Because of creation of qp fails, the function rxe_create_qp will
call rxe_qp_do_cleanup to handle allocated resource.

Before calling __rxe_do_task, both qp->req.task.func and
qp->req.task.arg should be checked.

Fixes: 8700e3e7 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/20220822011615.805603-2-yanjun.zhu@linux.dev


Reported-by: default avatar <syzbot+ab99dc4c6e961eed8b8e@syzkaller.appspotmail.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Reviewed-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent bfb3bde9

drivers/infiniband/sw/rxe/rxe_qp.c

+3 −1
Original line number Diff line number Diff line
@@ -797,7 +797,9 @@ static void rxe_qp_do_cleanup(struct work_struct *work) 
	rxe_cleanup_task(&qp->comp.task);



	/* flush out any receive wr's or pending requests */

	if (qp->req.task.func)

		__rxe_do_task(&qp->req.task);



	if (qp->sq.queue) {

		__rxe_do_task(&qp->comp.task);

		__rxe_do_task(&qp->req.task);