Commit a66f2017 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: hwdrv_apci3501: remove useless read/mask to stop watchdog 



The watchdog is stopped in apci3501_write_insn_timer() by writing a 0 to
the timer control register. There is no need to read the register first
and mask it (as done when the timer is used as a timer).

Reported-by: coverity (CID 1227052)
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2be8ae58

drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c

+0 −2
Original line number Diff line number Diff line
@@ -102,8 +102,6 @@ static int apci3501_write_insn_timer(struct comedi_device *dev, 
			/* Enable the Watchdog */

			outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);

		} else if (data[1] == 0) { /* Stop The Watchdog */

			ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);

			ul_Command1 = ul_Command1 & 0xFFFFF9FEUL;

			outl(0x0, dev->iobase + APCI3501_TIMER_CTRL_REG);

		} else if (data[1] == 2) {

			ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);