Commit a6828b1e authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Helge Deller
Browse files

fbdev: omapfb: panel-lgphilips-lb035q02: remove backlight GPIO handling 



With f048e8c1 ("omapfb: panel-lgphilips-lb035q02: Remove legacy boot
support") it is no longer possible to specify GPIO to control the
backlight. Remove code trying to request and toggle it.

Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 891bbadf

drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c

+1 −20
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ 
#include <linux/delay.h>

#include <linux/spi/spi.h>

#include <linux/mutex.h>

#include <linux/gpio.h>

#include <linux/gpio/consumer.h>



#include <video/omapfb_dss.h>
@@ -46,9 +46,6 @@ struct panel_drv_data { 


	struct omap_video_timings videomode;



	/* used for non-DT boot, to be removed */

	int backlight_gpio;



	struct gpio_desc *enable_gpio;

};
@@ -166,9 +163,6 @@ static int lb035q02_enable(struct omap_dss_device *dssdev) 
	if (ddata->enable_gpio)

		gpiod_set_value_cansleep(ddata->enable_gpio, 1);



	if (gpio_is_valid(ddata->backlight_gpio))

		gpio_set_value_cansleep(ddata->backlight_gpio, 1);



	dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;



	return 0;
@@ -185,9 +179,6 @@ static void lb035q02_disable(struct omap_dss_device *dssdev) 
	if (ddata->enable_gpio)

		gpiod_set_value_cansleep(ddata->enable_gpio, 0);



	if (gpio_is_valid(ddata->backlight_gpio))

		gpio_set_value_cansleep(ddata->backlight_gpio, 0);



	in->ops.dpi->disable(in);



	dssdev->state = OMAP_DSS_DISPLAY_DISABLED;
@@ -250,8 +241,6 @@ static int lb035q02_probe_of(struct spi_device *spi) 


	ddata->enable_gpio = gpio;



	ddata->backlight_gpio = -ENOENT;



	in = omapdss_of_find_source_for_first_ep(node);

	if (IS_ERR(in)) {

		dev_err(&spi->dev, "failed to find video source\n");
@@ -284,13 +273,6 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi) 
	if (r)

		return r;



	if (gpio_is_valid(ddata->backlight_gpio)) {

		r = devm_gpio_request_one(&spi->dev, ddata->backlight_gpio,

				GPIOF_OUT_INIT_LOW, "panel backlight");

		if (r)

			goto err_gpio;

	}



	ddata->videomode = lb035q02_timings;



	dssdev = &ddata->dssdev;
@@ -310,7 +292,6 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi) 
	return 0;



err_reg:

err_gpio:

	omap_dss_put_device(ddata->in);

	return r;

}