Commit a6e43263 authored by Nicolin Chen's avatar Nicolin Chen Committed by Guenter Roeck
Browse files

hwmon: (ina3221) Validate shunt resistor value from DT 



The input->shunt_resistor is int type while the value from DT is
unsigned int. Meanwhile, a divide-by-zero error would happen if
the value is 0. So this patch just simply validates the value.

Signed-off-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 8b9bf554

drivers/hwmon/ina3221.c

+7 −1
Original line number Diff line number Diff line
@@ -536,8 +536,14 @@ static int ina3221_probe_child_from_dt(struct device *dev, 
	of_property_read_string(child, "label", &input->label);



	/* Overwrite default shunt resistor value optionally */

	if (!of_property_read_u32(child, "shunt-resistor-micro-ohms", &val))

	if (!of_property_read_u32(child, "shunt-resistor-micro-ohms", &val)) {

		if (val < 1 || val > INT_MAX) {

			dev_err(dev, "invalid shunt resistor value %u of %s\n",

				val, child->name);

			return -EINVAL;

		}

		input->shunt_resistor = val;

	}



	return 0;

}