Commit a6f7baa3 authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/amd/amdgpu: Simplify switch case statements in amdgpu_connectors.c 



Fix the following checkpatch errors:

ERROR: trailing statements should be on next line
ERROR: space required after that ',' (ctx:VxV)
ERROR: code indent should use tabs where possible

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9f58341d

drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c

+29 −10
Original line number Diff line number Diff line
@@ -593,11 +593,20 @@ static int amdgpu_connector_set_property(struct drm_connector *connector, 


		switch (val) {

		default:

		case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;

		case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;

		case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;

		case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;

		case DRM_MODE_SCALE_NONE:

			rmx_type = RMX_OFF;

			break;

		case DRM_MODE_SCALE_CENTER:

			rmx_type = RMX_CENTER;

			break;

		case DRM_MODE_SCALE_ASPECT:

			rmx_type = RMX_ASPECT;

			break;

		case DRM_MODE_SCALE_FULLSCREEN:

			rmx_type = RMX_FULL;

			break;

		}



		if (amdgpu_encoder->rmx_type == rmx_type)

			return 0;
@@ -799,12 +808,21 @@ static int amdgpu_connector_set_lcd_property(struct drm_connector *connector, 
	}



	switch (value) {

	case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;

	case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;

	case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;

	case DRM_MODE_SCALE_NONE:

		rmx_type = RMX_OFF;

		break;

	case DRM_MODE_SCALE_CENTER:

		rmx_type = RMX_CENTER;

		break;

	case DRM_MODE_SCALE_ASPECT:

		rmx_type = RMX_ASPECT;

		break;

	default:

	case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;

	case DRM_MODE_SCALE_FULLSCREEN:

		rmx_type = RMX_FULL;

		break;

	}



	if (amdgpu_encoder->rmx_type == rmx_type)

		return 0;
@@ -1127,7 +1145,8 @@ amdgpu_connector_dvi_detect(struct drm_connector *connector, bool force) 
					/* assume digital unless load detected otherwise */

					amdgpu_connector->use_digital = true;

					lret = encoder_funcs->detect(encoder, connector);

					DRM_DEBUG_KMS("load_detect %x returned: %x\n",encoder->encoder_type,lret);

					DRM_DEBUG_KMS("load_detect %x returned: %x\n",

						      encoder->encoder_type, lret);

					if (lret == connector_status_connected)

						amdgpu_connector->use_digital = false;

				}