Commit a7a73697 authored by Marco Elver's avatar Marco Elver Committed by Paul E. McKenney
Browse files

kcsan: Remove CONFIG_KCSAN_DEBUG 



By this point CONFIG_KCSAN_DEBUG is pretty useless, as the system just
isn't usable with it due to spamming console (I imagine a randconfig
test robot will run into this sooner or later). Remove it.

Back in 2019 I used it occasionally to record traces of watchpoints and
verify the encoding is correct, but these days we have proper tests. If
something similar is needed in future, just add it back ad-hoc.

Signed-off-by: default avatarMarco Elver <elver@google.com>
Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent eb32f9f9

kernel/kcsan/core.c

+0 −9
Original line number Diff line number Diff line
@@ -479,15 +479,6 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type) 
		break; /* ignore; we do not diff the values */

	}



	if (IS_ENABLED(CONFIG_KCSAN_DEBUG)) {

		kcsan_disable_current();

		pr_err("watching %s, size: %zu, addr: %px [slot: %d, encoded: %lx]\n",

		       is_write ? "write" : "read", size, ptr,

		       watchpoint_slot((unsigned long)ptr),

		       encode_watchpoint((unsigned long)ptr, size, is_write));

		kcsan_enable_current();

	}



	/*

	 * Delay this thread, to increase probability of observing a racy

	 * conflicting access.

lib/Kconfig.kcsan

+0 −3
Original line number Diff line number Diff line
@@ -62,9 +62,6 @@ config KCSAN_VERBOSE 
	  generated from any one of them, system stability may suffer due to

	  deadlocks or recursion.  If in doubt, say N.



config KCSAN_DEBUG

	bool "Debugging of KCSAN internals"



config KCSAN_SELFTEST

	bool "Perform short selftests on boot"

	default y