Commit a8dce6b4 authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove rtl8188eu_init_xmit_priv 



rtl8188eu_init_xmit_priv's only jobs is to initialise the xmit tasklet.

Remove rtl8188eu_init_xmit_priv and initialise the xmit tasklet in
_rtw_init_xmit_priv. Yet again, this makes the code a tiny bit smaller.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-8-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9431a937

drivers/staging/r8188eu/core/rtw_xmit.c

+1 −1
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) 
	mutex_init(&pxmitpriv->ack_tx_mutex);

	rtw_sctx_init(&pxmitpriv->ack_tx_ops, 0);



	rtl8188eu_init_xmit_priv(padapter);

	tasklet_init(&pxmitpriv->xmit_tasklet, rtl8188eu_xmit_tasklet, (unsigned long)padapter);



	return 0;

drivers/staging/r8188eu/hal/rtl8188eu_xmit.c

+0 −10
Original line number Diff line number Diff line
@@ -9,16 +9,6 @@ 
#include "../include/usb_ops.h"

#include "../include/rtl8188e_hal.h"



s32	rtl8188eu_init_xmit_priv(struct adapter *adapt)

{

	struct xmit_priv	*pxmitpriv = &adapt->xmitpriv;



	tasklet_init(&pxmitpriv->xmit_tasklet,

		     rtl8188eu_xmit_tasklet,

		     (unsigned long)adapt);

	return _SUCCESS;

}



static void rtl8188eu_cal_txdesc_chksum(struct tx_desc	*ptxdesc)

{

	u16	*usptr = (u16 *)ptxdesc;

drivers/staging/r8188eu/include/rtl8188e_xmit.h

+0 −1
Original line number Diff line number Diff line
@@ -131,7 +131,6 @@ struct txrpt_ccx_88e { 


void rtl8188e_fill_fake_txdesc(struct adapter *padapter, u8 *pDesc,

			       u32 BufferLen, u8 IsPsPoll, u8 IsBTQosNull);

s32 rtl8188eu_init_xmit_priv(struct adapter *padapter);

s32 rtl8188eu_hal_xmit(struct adapter *padapter, struct xmit_frame *frame);

s32 rtl8188eu_mgnt_xmit(struct adapter *padapter, struct xmit_frame *frame);

s32 rtl8188eu_xmit_buf_handler(struct adapter *padapter);