Commit aa793b46 authored by Gao Xiang's avatar Gao Xiang
Browse files

erofs: simplify z_erofs_pcluster_readmore() 

Get rid of unnecessary label `skip'. No logic changes.

Link: https://lore.kernel.org/r/20220529055425.226363-4-xiang@kernel.org


Acked-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
parent 39397a46

fs/erofs/zdata.c

+10 −13
Original line number Original line Diff line number Diff line
@@ -1436,22 +1436,19 @@ static void z_erofs_pcluster_readmore(struct z_erofs_decompress_frontend *f, 
		struct page *page;

		struct page *page;





		page = erofs_grab_cache_page_nowait(inode->i_mapping, index);

		page = erofs_grab_cache_page_nowait(inode->i_mapping, index);

		if (!page)

		if (page) {

			goto skip;



			if (PageUptodate(page)) {

			if (PageUptodate(page)) {

				unlock_page(page);

				unlock_page(page);

			put_page(page);

			} else {

			goto skip;

		}



				err = z_erofs_do_read_page(f, page, pagepool);

				err = z_erofs_do_read_page(f, page, pagepool);

				if (err)

				if (err)

					erofs_err(inode->i_sb,

					erofs_err(inode->i_sb,

						  "readmore error at page %lu @ nid %llu",

						  "readmore error at page %lu @ nid %llu",

						  index, EROFS_I(inode)->nid);

						  index, EROFS_I(inode)->nid);

			}

			put_page(page);

			put_page(page);

skip:

		}



		if (cur < PAGE_SIZE)

		if (cur < PAGE_SIZE)

			break;

			break;

		cur = (index << PAGE_SHIFT) - 1;

		cur = (index << PAGE_SHIFT) - 1;