Unverified Commit ab76c891 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Mark Brown
Browse files

ASoC: cs35l56: Fix an unsigned comparison which can never be negative 



The variable 'rv' is defined as unsigned type, so the following if
statement is invalid, we can modify the type of rv to int.
if (rv < 0) {
	dev_err(cs35l56->dev, "irq: failed to get pm_runtime:
		%d\n", rv);
	goto err_unlock;
}

./sound/soc/codecs/cs35l56.c:333:5-7: WARNING: Unsigned expression compared with zero: rv < 0.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4599


Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230324022303.121485-1-jiapeng.chong@linux.alibaba.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 92405802

sound/soc/codecs/cs35l56.c

+3 −1
Original line number Diff line number Diff line
@@ -321,7 +321,9 @@ irqreturn_t cs35l56_irq(int irq, void *data) 
	struct cs35l56_private *cs35l56 = data;

	unsigned int status1 = 0, status8 = 0, status20 = 0;

	unsigned int mask1, mask8, mask20;

	unsigned int rv, val;

	unsigned int val;

	int rv;



	irqreturn_t ret = IRQ_NONE;



	if (!cs35l56->init_done)