Commit ac11ba75 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by David S. Miller
Browse files

tcp: don't backtrack to sacked skbs 



Backtracking to sacked skbs is a horrible performance killer
since the hint cannot be advanced successfully past them...
...And it's totally unnecessary too.

In theory this is 2.6.27..28 regression but I doubt anybody
can make .28 to have worse performance because of other TCP
improvements.

Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79cb5def

net/ipv4/tcp_output.c

+1 −1
Original line number Diff line number Diff line
@@ -2065,7 +2065,7 @@ void tcp_xmit_retransmit_queue(struct sock *sk) 
			goto begin_fwd;



		} else if (!(sacked & TCPCB_LOST)) {

			if (hole == NULL && !(sacked & TCPCB_SACKED_RETRANS))

			if (hole == NULL && !(sacked & (TCPCB_SACKED_RETRANS|TCPCB_SACKED_ACKED)))

				hole = skb;

			continue;