Commit ac98fc5e authored Apr 08, 2021 by Shixin Liu Committed by Herbert Xu Apr 16, 2021

crypto: sun4i-ss - Fix PM reference leak when pm_runtime_get_sync() fails



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 1aa33c7a

drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -561,7 +561,7 @@ int sun4i_ss_cipher_init(struct crypto_tfm *tfm)
		sizeof(struct sun4i_cipher_req_ctx) +
		crypto_skcipher_reqsize(op->fallback_tfm));

		err = pm_runtime_get_sync(op->ss->dev);
		err = pm_runtime_resume_and_get(op->ss->dev);
		if (err < 0)
		goto error_pm;

drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -454,7 +454,7 @@ static int sun4i_ss_probe(struct platform_device *pdev)
		* this info could be useful
		*/

		err = pm_runtime_get_sync(ss->dev);
		err = pm_runtime_resume_and_get(ss->dev);
		if (err < 0)
		goto error_pm;

drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -27,7 +27,7 @@ int sun4i_hash_crainit(struct crypto_tfm *tfm)
		algt = container_of(alg, struct sun4i_ss_alg_template, alg.hash);
		op->ss = algt->ss;

		err = pm_runtime_get_sync(op->ss->dev);
		err = pm_runtime_resume_and_get(op->ss->dev);
		if (err < 0)
		return err;

drivers/crypto/allwinner/sun4i-ss/sun4i-ss-prng.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -29,7 +29,7 @@ int sun4i_ss_prng_generate(struct crypto_rng tfm, const u8 src,
		algt = container_of(alg, struct sun4i_ss_alg_template, alg.rng);
		ss = algt->ss;

		err = pm_runtime_get_sync(ss->dev);
		err = pm_runtime_resume_and_get(ss->dev);
		if (err < 0)
		return err;